fix: use fs.stat to detect directory index #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`fs.ls` tells you the type of every directory entry - to do this it loads the first block of each entry to parse the unixfs metadata - this is obviously a bad idea for very large directories. Switch to `fs.stat` which only loads the directory entry we are interested in.
|
Seeing a transient WebRTC error that will be fixed by libp2p/js-libp2p#2299 |
SgtPooki
approved these changes
Dec 5, 2023
Comment on lines
+237
to
249
| let indexFile: UnixFSStats | null = null | ||
|
|
||
| for (const path of this.rootFilePatterns) { | ||
| try { | ||
| indexFile = await this.fs.stat(cid, { | ||
| ...options, | ||
| path | ||
| }) | ||
|
|
||
| break | ||
| } else { | ||
| this.log(`Skipping ${file.type} '${file.name}' in root CID because the filename is not in rootFilePatterns: ${this.rootFilePatterns}`) | ||
| } catch (err: any) { | ||
| this.log('error loading path %c/%s', cid, path, err) | ||
| } |
There was a problem hiding this comment.
For this, I remember you recommended using fs.ls instead of fs.stat
swap fs.stat() async race for root files (index.html, etc) to fs.ls iterator.. seems much faster (and less wasteful)
from #53. But this seems to be an improvement upon the original from https://github.com/ipfs/helia-http-gateway/pull/53/files#diff-685aae38f06a7057b61c9ef9d72086202a6729d8e63aee9395ef750557496d3eL234 for sure.
There was a problem hiding this comment.
Yeah, it was the wrong call 🤭
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fs.lstells you the type of every directory entry - to do this it loads the first block of each entry to parse the unixfs metadata - this is obviously bad news for very large directories.Switch to
fs.statwhich only loads the directory entry we are interested in.