Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Add BLAKE3 to allowed list #13

Closed
markg85 opened this issue Jan 19, 2022 · 6 comments
Closed

Add BLAKE3 to allowed list #13

markg85 opened this issue Jan 19, 2022 · 6 comments
Labels
P2 Medium: Good to have, but can wait until someone steps up

Comments

@markg85
Copy link

markg85 commented Jan 19, 2022

Hi,

multiformats/go-multihash#121 (comment) added support for BLAKE3.
Currently this is technically available in go-ipfs 0.11.

However, because BLAKE3 isn't in the list of allowed hashes one gets Error: potentially insecure hash functions not allowed
That is with a IPFS command line like:
ipfs add --nocopy --hash blake3 <somefile>

Could BLAKE3 be allowed too?

Best regards,
Mark

@markg85 markg85 added the need/triage Needs initial labeling and prioritization label Jan 19, 2022
@welcome
Copy link

welcome bot commented Jan 19, 2022

Thank you for submitting your first issue to this repository! A maintainer will be here shortly to triage and review.
In the meantime, please double-check that you have provided all the necessary information to make this process easy! Any information that can help save additional round trips is useful! We currently aim to give initial feedback within two business days. If this does not happen, feel free to leave a comment.
Please keep an eye on how this issue will be labeled, as labels give an overview of priorities, assignments and additional actions requested by the maintainers:

  • "Priority" labels will show how urgent this is for the team.
  • "Status" labels will show if this is ready to be worked on, blocked, or in progress.
  • "Need" labels will indicate if additional input or analysis is required.

Finally, remember to use https://discuss.ipfs.io if you just need general support.

@titusz
Copy link

titusz commented Jan 22, 2022

See: ipfs/kubo#8650

@markg85
Copy link
Author

markg85 commented Jan 22, 2022

Awesome! Thank you for the pointer.
I'm not quite sure if this issue needs to be closed now..? It looks like it kinda depends on how it's going to be solved in ipfs/kubo#8650 If a --force option would allow it then this issue would essentially be a non-issue.

@aschmahmann aschmahmann added P2 Medium: Good to have, but can wait until someone steps up and removed need/triage Needs initial labeling and prioritization labels Feb 25, 2022
@laudiacay
Copy link
Contributor

Adding an upvote to this issue :) our project would love if IPFS/multihash supported blake3. Would make our infrastructure much easier to build.

@Jorropo
Copy link
Contributor

Jorropo commented Aug 15, 2022

Done in #16 !

@Jorropo Jorropo closed this as completed Aug 15, 2022
@laudiacay
Copy link
Contributor

laudiacay commented Aug 15, 2022 via email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P2 Medium: Good to have, but can wait until someone steps up
Projects
None yet
Development

No branches or pull requests

5 participants