Skip to content
This repository has been archived by the owner on Jun 27, 2023. It is now read-only.

decouple the DAG traversal logic from the DAG reader (local branch) #60

Merged
merged 4 commits into from
Jan 30, 2019
Merged

decouple the DAG traversal logic from the DAG reader (local branch) #60

merged 4 commits into from
Jan 30, 2019

Commits on Jan 29, 2019

  1. unixfs: decouple the DAG traversal logic from the DAG reader 

    Decouple the DAG traversal logic from the `PBDagReader` encapsulating it in the
(new) `Walker` structure.

Collapse PB and Buffer DAG readers into one (`dagReader`) removing the
`bufdagreader.go` and `pbdagreader.go` files, moving all the code to
`dagreader.go`.

Remove `TestSeekAndReadLarge` and `TestReadAndCancel` which operated directly on
the `NodePromise` structure that is now abstracted away in `NavigableIPLDNode`,
in the `go-ipld-format` repo, where they should be recreated.

License: MIT
Signed-off-by: Lucas Molas <schomatis@gmail.com>
    @schomatis @magik6k
    schomatis authored and magik6k committed Jan 29, 2019
    Configuration menu
    Copy the full SHA
    ecd031d View commit details
    Browse the repository at this point in the history

  2. io: implement a performant WriteTo version in the DAG reader 

    This version writes one node at a time instead of first buffering the entire
file contents in a single array (taking up too much memory) before actually
writing it.
    @schomatis @magik6k
    schomatis authored and magik6k committed Jan 29, 2019
    Configuration menu
    Copy the full SHA
    ac466e6 View commit details
    Browse the repository at this point in the history

  3. io: return nil when EOF is reached in WriteTo

    @magik6k
    magik6k committed Jan 29, 2019
    Configuration menu
    Copy the full SHA
    9dacd09 View commit details
    Browse the repository at this point in the history

  4. io: correctly handle seek offset with io.SeekEnd

    @magik6k
    magik6k committed Jan 29, 2019
    Configuration menu
    Copy the full SHA
    cdb64d5 View commit details
    Browse the repository at this point in the history