Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Resolve(nil) return map of top-level objects, fixes #20 #35

Closed
wants to merge 1 commit into from

Conversation

sameer
Copy link
Contributor

@sameer sameer commented Jan 6, 2019

I added a mapping to the top-level objects where appropriate. Please let me know if I missed something.

Copy link
Member

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A test would be nice

@magik6k magik6k added the status/blocked Unable to be worked further until needs are met label Jan 6, 2019
@sameer sameer force-pushed the resolvenil branch 2 times, most recently from 86ba0f6 to 816a33a Compare September 27, 2019 18:58
@sameer
Copy link
Contributor Author

sameer commented Sep 27, 2019

  • Updated to work with the date format changes
  • Added tests for all the resolve methods to make sure they returns something valid
    • Discovered commit.Sig.Text dereferences a null pointer when there's no signature which I've fixed in this PR too

@Stebalien Stebalien requested a review from magik6k October 24, 2019 01:48
@rvagg rvagg closed this Aug 3, 2021
@sameer
Copy link
Contributor Author

sameer commented Aug 3, 2021

Hello, has this issue been resolved?

@rvagg
Copy link
Member

rvagg commented Aug 4, 2021

Sorry @sameer! I closed this because we're getting up on 2 years now and I made the (obviously false) assumption that it was stale. We've done quite a bit of work in #46 that will soon be merged and it's a big divergence from the current codebase.

The new code uses https://github.com/ipld/go-ipld-prime as its basis, which will be used for traversal and node resolution, which removes resolve concerns from the codecs themselves. I believe that resolving to the root of one of these nodes should just give you the node as it is, like this PR was trying to do.

I've added some tests in go-ipfs that I think demonstrate that resolution is working as intended by this PR now that we have all the data in ipld-prime form: ipfs/kubo@bbc722b#diff-376e0b27fef811d85269a61a2b09648655b95dfd0a9136adf278061dbb23a1da (part of ipfs/kubo#7976). Let me know if you think there's something amiss.

@sameer
Copy link
Contributor Author

sameer commented Aug 4, 2021

Was just curious, thanks for the update! 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/blocked Unable to be worked further until needs are met
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants