Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

replace go-merkledag with go-fetcher #30

Merged
merged 9 commits into from
Mar 17, 2021
Merged

Conversation

acruikshank
Copy link
Contributor

Motivation

As part of a broader effort to use IPLD prime in IPFS, we want to start replacing read only usages of go-merkledag with go-fetcher. This PR replaces the usage of merkledag.Walk with fetcher.Session.BlockAll to retrieve all links from a potentially remote Dag.

@welcome
Copy link

welcome bot commented Mar 2, 2021

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

@willscott
Copy link
Contributor

looks good. we'll need to wait for the pending ipld-prime PR to land since it changes a bit the encoder interface, right?

@willscott
Copy link
Contributor

we may consider releasing this as a v1.0 (semver major breaking release) and maintaining a branch for any needed patch fixes of the v0.x implementation.

@acruikshank acruikshank merged commit 7463091 into master Mar 17, 2021
Stebalien added a commit that referenced this pull request Mar 22, 2021
This reverts commit 7463091, reversing
changes made to b8fd93c.
@Stebalien
Copy link
Member

Note: I've reverted this PR in #31 to avoid breaking changes on master till they're ready. Please re-file it against a branch if you need it for something.

willscott added a commit that referenced this pull request Apr 2, 2021
@willscott willscott mentioned this pull request Apr 2, 2021
@aschmahmann aschmahmann mentioned this pull request May 14, 2021
71 tasks
hannahhoward pushed a commit that referenced this pull request Jul 28, 2021
Jorropo pushed a commit to ipfs/go-libipfs-rapide that referenced this pull request Mar 23, 2023
…rime

replace go-merkledag with go-fetcher

This commit was moved from ipfs/go-ipfs-provider@7463091
Jorropo pushed a commit to ipfs/go-libipfs-rapide that referenced this pull request Mar 23, 2023
…e_ipld_prime"

This reverts commit bbafe76, reversing
changes made to b8fd93c8e02bf176c5649b5684e535f51ae8686c.


This commit was moved from ipfs/go-ipfs-provider@46797b1
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants