Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync: update CI config files #207

Merged
merged 8 commits into from
Aug 25, 2021
Merged

sync: update CI config files #207

merged 8 commits into from
Aug 25, 2021

Conversation

web3-bot
Copy link
Collaborator

@web3-bot web3-bot commented Apr 23, 2021

Syncing to commit protocol/.github@928c600.

@welcome
Copy link

welcome bot commented Apr 23, 2021

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

@masih
Copy link
Member

masih commented Jul 21, 2021

Failing check fixed here: #212

@masih
Copy link
Member

masih commented Jul 22, 2021

The tests on windows fail because CLI parser explicitly converts paths to slash here, which then is passed to the error message. The error message on windows tests expect backslash separators, where the code always returns slash.

We can change the tests or the code to comply; the question is which one is intended behaviour?

Cc @aschmahmann @aschmahmann @marten-seemann

@marten-seemann
Copy link
Member

Is there any reason not to use the os.FileSeparator?

@masih
Copy link
Member

masih commented Jul 22, 2021

Is there any reason not to use the os.FileSeparator?

Not that I can think of.
The code explicitly doesn't. I'd love input from folks whom know this repo as I am conscious I may be missing something.

@Stebalien
Copy link
Member

This is definitely a bug. We convert to "unix" paths for IPFS, but these should just be normal windows paths: #214

@Stebalien Stebalien merged commit a6eabdc into master Aug 25, 2021
@Stebalien Stebalien deleted the web3-bot/sync branch August 25, 2021 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants