fix(add): refer to ipfs issue #5456 #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@keks I'm trying to solve the ipfs/kubo#5456, but i have no idea whether my solution is correct, could you help me review my pr? Thx |
overbool
force-pushed
the
fix/ipfs-#5456
branch
2 times, most recently
from
738f586
to
2abaff8
Compare
overbool
changed the title
|
I think this is the correct fix but I'd like @keks to sign off on it. |
|
However, it needs a |
keks
suggested changes
Sep 18, 2018
License: MIT Signed-off-by: Overbool <overbool.xu@gmail.com>
overbool
force-pushed
the
fix/ipfs-#5456
branch
from
2abaff8
to
dfd79a5
Compare
|
@Stebalien @keks I had fixed it |
|
This looks good! @Stebalien do you think there should be a test for this edge case to prevent regressions? |
|
@keks yes. However, I like merging bug fixes, with or without tests, as long as we leave the bug open. |
Stebalien
approved these changes
Sep 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
License: MIT
Signed-off-by: Overbool overbool.xu@gmail.com
Fixes: ipfs/kubo#5456