This repository has been archived by the owner on Apr 24, 2021. It is now read-only.
feat(type): fix issue #28 #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
overbool
force-pushed
the
feat/issue-#28
branch
from
e48dff0
to
3687083
Compare
overbool
force-pushed
the
feat/issue-#28
branch
from
3687083
to
ff74515
Compare
|
@Stebalien could you help me review it? Thx |
keks
approved these changes
Sep 28, 2018
There was a problem hiding this comment.
Looks Great! I don't think we need @Stebalien to review this, but let's give him a day or two to comment.
|
Looks like ipfs-inactive/dev-team-enablement#132 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #28