This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
fix size-0 chunker bug #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevina
reviewed
Sep 29, 2018
| @@ -23,6 +26,8 @@ func FromString(r io.Reader, chunker string) (Splitter, error) { | |||
| size, err := strconv.Atoi(sizeStr) | |||
| if err != nil { | |||
| return nil, err | |||
| } else if size <= 0 { | |||
| return nil, ErrSize | |||
There was a problem hiding this comment.
This is fine. I think it would be better though to have NewSizeSplitter verify its arguments are sane and return an error. But since NewRabinMinMax does not return an error it is not that big of a deal.
kevina
approved these changes
Sep 29, 2018
|
@kevina yeah ,if we change to |
|
You're both right. Yes, it's a breaking change but the current behavior is buggy anyways so I'd make the change and fix dependent packages. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix bug go-ipfs #5542