Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Rigorous sizing checks #21

Merged
merged 6 commits into from
Jan 22, 2020
Merged

Rigorous sizing checks #21

merged 6 commits into from
Jan 22, 2020

Conversation

ribasushi
Copy link
Contributor

No description provided.

ribasushi
ribasushi commented Jan 21, 2020
View reviewed changes
parse.go Show resolved Hide resolved
ribasushi
ribasushi commented Jan 21, 2020
View reviewed changes
parse.go Outdated Show resolved Hide resolved
@ribasushi
Copy link
Contributor Author

One general question to the group regarding the "nice round number" comment: are we ok with defining various limits in terms of 2^N as opposed to 2^N -1 ?
It doesn't really matter for our purposes ( both PB and CBOR have thresholds orthogonal to "amount of logical bits" ), but for various types of interop it might...

I am just raising this as a general question, as it doesn't seem to have been addressed as a whole.

Stebalien
Stebalien approved these changes Jan 22, 2020
View reviewed changes
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

(I'm also fine punting the NewRabin changes till some unspecified future date. I.e., we can get to it when we get to it).

@Stebalien Stebalien merged commit 72733e3 into master Jan 22, 2020
@Stebalien Stebalien deleted the fix_rigorous_sizing_checks branch January 22, 2020 17:39
@ribasushi
Copy link
Contributor Author

regarding the "nice round number" comment: are we ok with defining various limits in terms of 2^N as opposed to 2^N - 1

Note to the rest: we did discuss it with @Stebalien over Zoom, and the agreement is that we are ok with general 2^N "nice round number" specificiations pretty much everywhere.

@aschmahmann aschmahmann mentioned this pull request Apr 25, 2022
Merged
Jorropo pushed a commit to ipfs/go-libipfs-rapide that referenced this pull request Mar 23, 2023
@Stebalien
Merge pull request ipfs/go-ipfs-chunker#21 from ipfs/fix_rigorous_siz…
aff0ae7 
…ing_checks

Rigorous sizing checks

This commit was moved from ipfs/go-ipfs-chunker@72733e3
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mikeal mikeal mikeal left review comments

@Stebalien Stebalien Stebalien approved these changes

@dirkmc dirkmc Awaiting requested review from dirkmc

@Kubuxu Kubuxu Awaiting requested review from Kubuxu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ribasushi @mikeal @Stebalien