This repository has been archived by the owner on Jun 19, 2023. It is now read-only.
fix test race condition #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also stop exposing functions that don't do what they claim to do: * Invalidate does, technically invalidate. However, it's not threadsafe. * Rebuild doesn't *clear* the filter so it's only useful for the initial build. It's also not threadsafe. We can restore these functions later if we need them (but we'll have to change a few things to make them work properly). Also adds a `Wait` function to allow waiting for the bloom filter to finish building. fixes #6
Stebalien
commented
Aug 6, 2018
| case <-ctx.Done(): | ||
| return ctx.Err() | ||
| case <-b.buildChan: | ||
| return b.buildErr |
There was a problem hiding this comment.
This way we have a way of getting at these errors.
Stebalien
commented
Aug 6, 2018
| @@ -102,7 +98,7 @@ func TestHasIsBloomCached(t *testing.T) { | |||
| } | |||
|
|
|||
| if float64(cacheFails)/float64(1000) > float64(0.05) { | |||
| t.Fatal("Bloom filter has cache miss rate of more than 5%") | |||
| t.Fatalf("Bloom filter has cache miss rate of more than 5%%") | |||
Stebalien
commented
Aug 6, 2018
| // This chan is only used for testing to wait for bloom to enable | ||
| rebuildChan chan struct{} | ||
| blockstore Blockstore | ||
| bloom *bloom.Bloom |
There was a problem hiding this comment.
Put the atomic first because go can be stupid about things like this.
Stebalien
commented
Aug 6, 2018
| "Total number of requests to bloom cache").Counter(), | ||
| buildChan: make(chan struct{}), | ||
| } | ||
| go func() { |
There was a problem hiding this comment.
Might as well do this all in one goroutine.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also stop exposing functions that don't do what they claim to do:
It's also not threadsafe.
We can restore these functions later if we need them (but we'll have to change a
few things to make them work properly).
Also adds a
Waitfunction to allow waiting for the bloom filter to finishbuilding.
fixes #6