chore(requestmanager): rename processResponses internals for consistency #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannahhoward
approved these changes
Jan 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a consistency thing that I noticed while working on internal docs for the requestmanager code. In all other cases, the name of the public API in client.go matches a private version in server.go, just lower cased, and the message between them just has
Messageappended to the end. In this case,ProcessResponsesmaps toprocessResponseMessagewhich is also the name of the message that invokes it. So I've made the privateprocessResponsesand the messageprocessResponsesMessage. The tracing span name, and some logging text also changes too to be consistent.