Update Datastore Interface #60
Conversation
aschmahmann
force-pushed
the
feat/ds-update
branch
from
333fe37
to
7bcfd81
Compare
| return ErrClosed | ||
| } | ||
|
|
||
| return nil |
There was a problem hiding this comment.
Is this the approach we want here? I see that FlatFS has support for both sync and async operation (async seems to be the default, but IPFS uses the sync version by default).
Do we want to support some sort of sync here in the event that the datastore is running in async mode? If so is it important enough to do something now or should I just file an issue?
There was a problem hiding this comment.
Let's file an issue and leave this as-is for now.
A correct implementation would need to call fsync on all changed files. Doing so would require keeping track of file changes (or relying on timestamps).
| return ErrClosed | ||
| } | ||
|
|
||
| return nil |
There was a problem hiding this comment.
Let's file an issue and leave this as-is for now.
A correct implementation would need to call fsync on all changed files. Doing so would require keeping track of file changes (or relying on timestamps).
Stebalien
force-pushed
the
feat/ds-update
branch
from
7bcfd81
to
20a4649
Compare
Per ipfs/go-datastore#140 the Datastore interface is being updated to support asynchronous writes.
This PR should be approved before the above PR is merged. After ipfs/go-datastore#140 is merged then this PR should have its go.mod updated and merged.