This repository has been archived by the owner on Feb 1, 2023. It is now read-only.
fix: fix a map access race condition in the want index #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
force-pushed
the
fix/race
branch
2 times, most recently
from
ef24152
to
c0ce901
Compare
aschmahmann
approved these changes
Jul 30, 2021
internal/decision/engine.go
Outdated
Comment on lines
660
to
672
| if hasLedger { | ||
| ledger.lk.RLock() | ||
| } | ||
| for _, k := range wl { | ||
| if hasLedger { | ||
| if _, has := ledger.WantListContains(k); has { | ||
| continue | ||
| } | ||
| } | ||
| e.peerLedger.CancelWant(p, k) | ||
| } | ||
| if hasLedger { | ||
| ledger.lk.RUnlock() | ||
| } |
There was a problem hiding this comment.
nit: IMO it'd be easier to read this if we separated all the hasLedger pieces out and just had an if/else or an if + return.
Yes. On the happy path we just read the map so we only need a read lock. On the sad path, we need to take the lock. |
Jorropo
pushed a commit
to Jorropo/go-libipfs
that referenced
this pull request
Jan 26, 2023
fix: fix a map access race condition in the want index This commit was moved from ipfs/go-bitswap@5c2c537
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should have better tests here, but I'm not sure how to go about that. We basically need a fuzzer.