Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tests): properly test negative indexing #190

Merged
merged 2 commits into from
Jan 25, 2024
Merged

fix(tests): properly test negative indexing #190

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4bd19e7
fix(tests): properly test negative indexing
hannahhoward Dec 8, 2023
7ed58d1
refactor: explain what we test and why
lidel Jan 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/trustless_gateway_car_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -634,7 +634,7 @@ func TestTrustlessCarEntityBytes(t *testing.T) {
HasBlocks(
flattenStrings(t,
subdirWithMixedBlockFiles.MustGetCid("subdir", "multiblock.txt"),
subdirWithMixedBlockFiles.MustGetDescendantsCids("subdir", "multiblock.txt")[:5])...,
subdirWithMixedBlockFiles.MustGetDescendantsCids("subdir", "multiblock.txt")[:len(subdirWithMixedBlockFiles.MustGetDescendantsCids("subdir", "multiblock.txt"))-1])...,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#189 highlights the instance of problem flagged in #112

we should avoid generating code in cases like this, where we have small number of CIDs, just write them inline. The list is small enough to not pollute test case, and makes it immune to boxo bugs/regressions.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrote some thoughts in #112 (comment), but that work is separate from fix here, not a blocker.

).
Exactly().
InThatOrder(),
Expand Down
Loading