feat: disallow awaiting non thenable values #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpetrunic
changed the title
wemeetagain
approved these changes
Jul 14, 2022
achingbrain
requested changes
Jul 25, 2022
achingbrain
changed the title
mpetrunic
changed the title
achingbrain
changed the title
achingbrain
added a commit
to ipfs/aegir
that referenced
this pull request
Jan 12, 2023
Updates all deps to the latest versions. Includes new linting rules from `eslint-config-ipfs` that require return types on all methods to prevent tsc creating verbose derived types when we normally meant to specify that a function returns an interface. - ipfs/eslint-config-ipfs#114 - ipfs/eslint-config-ipfs#110 BREAKING CHANGE: all functions and methods need to declare a return type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add promise related lint rules