Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editing contributing #65

Merged
merged 1 commit into from
Jan 8, 2016
Merged

Editing contributing #65

merged 1 commit into from
Jan 8, 2016

Conversation

RichardLitt
Copy link
Member

I added a "Helping in other ways" section, and moved the commit sign off message to go-ipfs. This is only used in go-ipfs. I have moved it to the contribution guidelines for that repository, and have opened PR. I ran into at least one contributor who was intimidated by this section, and it is not currently mandatory for all repositories (although it potentially should be).

@jbenet jbenet added the status/in-progress In progress label Nov 2, 2015
@RichardLitt RichardLitt mentioned this pull request Nov 2, 2015
Merged
@RichardLitt
Copy link
Member Author

This is the last PR related to #63.

@jbenet
Copy link
Member

jbenet commented Nov 2, 2015

and moved the commit sign off message to go-ipfs. This is only used in go-ipfs. ... I ran into at least one contributor who was intimidated by this section, and it is not currently mandatory for all repositories (although it potentially should be).

yep, we should be using it elsewhere and will be as time goes on. let's keep the discussion here.

i think we need to make the thing less scary somehow. I think the doc should be friendlier. maybe gitcop is too angry right now? -- maybe we could make the message more pleasant? (maybe with a gif)

@RichardLitt
Copy link
Member Author

Fixed conflicts. May want to wait until #83 is merged, I think we should keep the commit sign off section now, as we'll be using it later.

@RichardLitt
Copy link
Member Author

Maybe we should just cherry pick and use f5d2d53 and c00d61b, but not 52d9b9d?

@RichardLitt RichardLitt mentioned this pull request Dec 7, 2015
Closed
14 tasks
@dignifiedquire
Copy link
Member

More conflicts, otherwise LGTM

@RichardLitt RichardLitt force-pushed the feature/edit-contribute branch 2 times, most recently from ad8d973 to b1c8309 Compare January 7, 2016 19:27
@RichardLitt
Copy link
Member Author

@dignifiedquire Thanks. I removed the offensive commit, and fixed conflicts.

@RichardLitt
Copy link
Member Author

@jbenet Look good?

@RichardLitt
Small edits
98d4664 
Added note about emailing Juan

This was in the main ipfs/ipfs repo, and belonged here too. I also removed a
couple of blank lines.

See #63 for more.
RichardLitt added a commit that referenced this pull request Jan 8, 2016
@RichardLitt
Merge pull request #65 from ipfs/feature/edit-contribute
90bc2a4 
Editing contributing
@RichardLitt RichardLitt merged commit 90bc2a4 into master Jan 8, 2016
@RichardLitt RichardLitt deleted the feature/edit-contribute branch January 8, 2016 23:05
@jbenet jbenet removed the status/in-progress In progress label Jan 8, 2016
@jbenet
Copy link
Member

jbenet commented Jan 8, 2016

(ep LGTM (we reviewed in person)

On Fri, Jan 8, 2016 at 6:05 PM Richard Littauer notifications@github.com
wrote:

Merged #65 #65.

—
Reply to this email directly or view it on GitHub
#65 (comment).

@RichardLitt
Copy link
Member Author

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RichardLitt @jbenet @dignifiedquire