Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update required node version to node 18 and npm 8 #1184

Merged
merged 2 commits into from
May 9, 2023

Conversation

whizzzkid
Copy link
Contributor

Based on: ipfs/helia#30

src/check-project/utils.js Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@achingbrain achingbrain changed the title fix: 📌 Pinning to node 18 and npm 9 fix: Update required node version to node 18 and npm 8 May 2, 2023
@achingbrain
Copy link
Member

This may need revising in future to correct the minor/patch version.

@achingbrain achingbrain merged commit b7ef86c into master May 9, 2023
@achingbrain achingbrain deleted the fix/min-node-version branch May 9, 2023 15:40
github-actions bot pushed a commit that referenced this pull request May 9, 2023
## [39.0.6](v39.0.5...v39.0.6) (2023-05-09)

### Bug Fixes

* Update required node version to node 18 and npm 8 ([#1184](#1184)) ([b7ef86c](b7ef86c))
@github-actions
Copy link

github-actions bot commented May 9, 2023

🎉 This PR is included in version 39.0.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

achingbrain added a commit that referenced this pull request May 17, 2023
The engines field causes warnings on npm but errors on yarn when the
required node version is not met.

Not all of our modules require LTS node and they are used by projects
outside of libp2p/helia/etc.

This change removes the automatic addition of an engines field to a
project's `package.json` while running the `check-project` command,
instead projects that do require a certain node version are free to
define it and deal with the breakage that subsequently occurs.

Partial revert of: #1184
Refs: #1276
achingbrain added a commit that referenced this pull request May 19, 2023
The engines field causes warnings on npm but errors on yarn when the
required node version is not met.

Not all of our modules require LTS node and they are used by projects
outside of libp2p/helia/etc.

This change removes the automatic addition of an engines field to a
project's `package.json` while running the `check-project` command,
instead projects that do require a certain node version are free to
define it and deal with the breakage that subsequently occurs.

Partial revert of: #1184
Refs: #1276
github-actions bot pushed a commit that referenced this pull request May 19, 2023
## [39.0.8](v39.0.7...v39.0.8) (2023-05-19)

### Bug Fixes

* do not enforce engines in package.json ([#1277](#1277)) ([5e9c2fa](5e9c2fa)), closes [#1184](#1184)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants