feat: branded SVG QR code #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces <canvas> with <svg> which looks sharper. We also add bit of branding, so it looks unique.
lidel
requested review from
jessicaschilling,
terichadbourne and
rafaelramalho19
|
We need to double-check if error-correction works on skewed screens tho 😅 |
jessicaschilling
approved these changes
Feb 5, 2021
This seems to work better when i scan my monitor from extreme angles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tweaks the way QR code is generated and replaces
<canvas>with<svg>which looks sharper (at least on my machine)It also adds a bit of branding, so it looks more native to the app (works due to error-correction built into QR codes)
(ok to revert this change – up for your consideration 🙈 )
QR code playground: https://zpao.github.io/qrcode.react/
URL of the icon: https://share.ipfs.io/favicon-32x32.png
(click to compare 1:1)