This repository has been archived by the owner on Aug 12, 2020. It is now read-only.
fix: import with CID version 1 #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using CID version 1 causes the raw leaves option to become `true` unless specified. The builder reducer was not expecting a raw leaf to be returned by ipld.get so was creating file nodes with empty data. fixes ipfs/js-ipfs#1518 License: MIT Signed-off-by: Alan Shaw <alan@tableflip.io>
ghost
assigned 
|
Published as |
7 tasks
lidel
added a commit
to lidel/js-ipfs-http-response
that referenced
this pull request
Sep 21, 2018
Old CIDs were invalid as noted in: ipfs-inactive/js-ipfs-unixfs-engine#227 License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using CID version 1 causes the raw leaves option to become
trueunless specified. The builder reducer was not expecting a raw leaf to be returned byipld.getso was creating file nodes with empty data.Improves the test to fetch the data for the CIDs created by the importer and assert the imported data is the same as the input data.
fixes ipfs/js-ipfs#1518