This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
Support shutdown #685
Merged
Support shutdown #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
daviddias
reviewed
Jan 31, 2018
src/utils/load-commands.js
Outdated
| @@ -33,6 +33,7 @@ function requireCommands () { | |||
| ping: require('../ping'), | |||
| refs: require('../refs'), | |||
| repo: require('../repo'), | |||
| shutdown: require('../shutdown'), | |||
There was a problem hiding this comment.
These commands should be behind daemon as in
ipfs daemon start and ipfs daemon stop. There are some old notes about it (need to find it)
There was a problem hiding this comment.
Well go-ipfs has implemented ipfs shutdown. It's the reference standard.
There was a problem hiding this comment.
|
@diasdavid RTM |
|
released |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue ipfs/js-ipfs#1192