This repository has been archived by the owner on Apr 16, 2021. It is now read-only.
fix: slow buffer serialization in firefox #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 17, 2018 21:54
It turns out `Array.from(buffer)` is way slower than `JSON.stringify(buffer)`. License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
lidel
added a commit
to ipfs/ipfs-companion
that referenced
this pull request
Sep 17, 2018
Closes #485 thanks to fix from ipfs-inactive/ipfs-postmsg-proxy#35
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out
Array.from(buffer)is way slower thanJSON.stringify(buffer).EDIT: Possibly not true, perhaps it's sending a large array over postMessage is way slower than sending a large string. Anyway, something like that. Either way this PR makes it fast in both Firefox and Chrome which is what we want!
I'm seeing numbers like 905ms in Firefox and 455ms in Chrome for the test case from ipfs/ipfs-companion#485