This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
docs: document --parents flag for files.write command #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adds a test. Already supported in `js-ipfs`, `go-ipfs` requires ipfs/kubo#5359 to be merged and released
ghost
assigned 
achingbrain
requested review from
alanshaw and
daviddias
and removed request for
travisperson and
victorb
victorb
reviewed
Aug 9, 2018
js/src/files/write.js
Outdated
| @@ -48,5 +48,14 @@ module.exports = (createCommon, options) => { | |||
| done() | |||
| }) | |||
| }) | |||
|
|
|||
| it('should write to deeply nested non existent file with create and parents flags, expect no error', function (done) { | |||
There was a problem hiding this comment.
This test doesn't actually test if a parent directory is being created, only that the function doesn't error
There was a problem hiding this comment.
That's true. Neither do the other tests present, nor do the related go-ipfs sharness tests.
There was a problem hiding this comment.
Looks better now though! Thanks for fixing it + the other test
achingbrain
force-pushed
the
document-parents-flag-for-write-command
branch
2 times, most recently
from
8fc2e29 to
40e5979
Compare
achingbrain
force-pushed
the
document-parents-flag-for-write-command
branch
from
40e5979 to
3835a06
Compare
victorb
approved these changes
Aug 9, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds a test.
Already supported in
js-ipfs,go-ipfsrequires ipfs/kubo#5359 to be merged and released