Skip to content
This repository has been archived by the owner on Jun 2, 2020. It is now read-only.

fix godoc building and update #277

Merged
merged 1 commit into from
Sep 19, 2019
Merged

fix godoc building and update #277

merged 1 commit into from
Sep 19, 2019

Conversation

Stebalien
Copy link
Contributor

@Stebalien Stebalien commented Sep 19, 2019

I went ahead and nuked the Go API docs:

  1. We weren't hosting our own JS API docs.
  2. Our Go API docs were inferior to godoc.org.
  3. Devs will be familiar with godoc.org as that's what we link to from our repos (also what every other project under the sun uses).
  4. Fixing this wasn't worth the effort.

The ones _we_ build are crappier and are painful to get building properly. We
might as well link to other documentation sources.

* These new sources will _always_ be up to date.
* The new go documentation will:
  * Properly hyperlink
  * Not require one sidebar link per package. We currently have links in the
    sidebar for subpackages that really don't belong as top-level links.
@jessicaschilling
Copy link
Contributor

Closes #276

@jessicaschilling jessicaschilling deleted the fix/godoc branch September 19, 2019 20:31
@Mr0grog
Copy link
Collaborator

Mr0grog commented Sep 19, 2019

FWIW, one of the main reasons we didn’t do this initially was to support a path towards #66, which godoc.org does not have great support for. NOT trying to disagree with this change (it’s probably the right move!); just want to provide some planning context if versioned API reference docs are still a major goal (I can’t see the spreadsheet linked from #66, but the comment makes it sound like it still is).

@jessicaschilling
Copy link
Contributor

@Mr0grog Thanks for finding that broken spreadsheet link! Spreadsheet creep -> separated the features list into this: https://docs.google.com/spreadsheets/d/1YJ8yuzoNeunVr3ftvm7x2nIKsj7IlTrsfuy71ZnGg6Y/edit#gid=785339355

Versioning is definitely a strong point on that roadmap -- specifically in API dictionaries but just in the docs as a whole.

Also, hi! I've really appreciated the opportunity to lurk hard on all your previous work. 😄

@Stebalien
Copy link
Contributor Author

Hm. You're right. Go module support in go doc (golang/gddo#567) should fix this but it's unclear how long that will take to land.

@Mr0grog
Copy link
Collaborator

Mr0grog commented Sep 20, 2019

Sweet, I had been wondering if godoc versioning would wind up coming along for the ride!

Also, hi! I've really appreciated the opportunity to lurk hard on all your previous work.

Awesome, happy if it’s helpful. 👋

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants