This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
feat: add proxy blockstore for testing against non-saturn backend #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidel
changed the title
lidel
suggested changes
Feb 21, 2023
hacdias
force-pushed
the
test-bs
branch
2 times, most recently
from
87cd7ab to
7b86715
Compare
|
@lidel I made it default, support more than one URL, chosen randomly. |
lidel
force-pushed
the
test-bs
branch
6 times, most recently
from
e47fd9c to
9ba968c
Compare
we explicitly require it to be set, to avoid situation where someone runs bufrost-gateway, has local ipfs-desktop, and thinks they use Saturn CDN ;-)
lidel
approved these changes
Feb 24, 2023
There was a problem hiding this comment.
Thank you @hacdias!
I've added some docs and for now require user to explicitly choose the backend by defining either PROXY_GATEWAY_URL or STRN_ORCHESTRATOR_URL.
This should remove any confusion around which backend is used, especially if someone runs local Kubo node and thinks they use Saturn.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
?format=rawgateway like ipfs.io or localhost Kubo.This can be useful for testing, as well as other use cases. Built on top of #48