Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: 移除对全局参数的缓存 / remove cached shared params #256

Merged
merged 1 commit into from
Sep 16, 2022

Conversation

simlecode
Copy link
Collaborator

@simlecode simlecode commented Sep 16, 2022

关联的Issues (Related Issues)

resolve filecoin-project/venus#5234

改动 (Proposed Changes)

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

@codecov-commenter
Copy link

Codecov Report

Merging #256 (b3d065c) into master (308f6ab) will decrease coverage by 0.14%.
The diff coverage is 61.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #256      +/-   ##
==========================================
- Coverage   54.75%   54.61%   -0.15%     
==========================================
  Files          63       63              
  Lines        6757     6740      -17     
==========================================
- Hits         3700     3681      -19     
- Misses       2767     2768       +1     
- Partials      290      291       +1     
Flag Coverage Δ
unittests 54.61% <61.11%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
service/message_service.go 60.46% <40.00%> (-0.16%) ⬇️
service/shared_params_service.go 62.50% <66.66%> (-7.96%) ⬇️
service/message_selector.go 86.25% <70.00%> (-0.98%) ⬇️

Copy link
Contributor

@diwufeiwen diwufeiwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@diwufeiwen diwufeiwen merged commit 5ff325d into master Sep 16, 2022
@diwufeiwen diwufeiwen deleted the fix/remove_cached_shared_params branch September 16, 2022 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

[venus-messager]删除messagestate缓存代码
3 participants