Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve docker usage #246

Merged
merged 3 commits into from
Sep 1, 2022
Merged

feat: improve docker usage #246

merged 3 commits into from
Sep 1, 2022

Conversation

LinZexiao
Copy link
Collaborator

@LinZexiao LinZexiao commented Aug 30, 2022

关联的Issues (Related Issues)

involve filecoin-project/venus#5240

改动 (Proposed Changes)

  • devide mod download and build when building docker
  • set default test tag to image
  • use unify dockerfile

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

- add default tag
- devide mod download and build
@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2022

Codecov Report

Merging #246 (7affbc5) into master (2b3d885) will increase coverage by 3.23%.
The diff coverage is 80.48%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #246      +/-   ##
==========================================
+ Coverage   50.64%   53.87%   +3.23%     
==========================================
  Files          63       63              
  Lines        6595     6767     +172     
==========================================
+ Hits         3340     3646     +306     
+ Misses       2954     2822     -132     
+ Partials      301      299       -2     
Flag Coverage Δ
unittests 53.87% <80.48%> (+3.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gateway/mock_gateway_client.go 69.69% <52.94%> (+1.69%) ⬆️
testhelper/mock_full_node.go 79.72% <79.00%> (+0.52%) ⬆️
service/message_service.go 58.99% <81.81%> (+8.48%) ⬆️
service/message_state_refresh.go 70.88% <82.60%> (+19.12%) ⬆️
integration_test/mock_messager_server.go 73.78% <100.00%> (ø)
models/mysql/message.go 77.31% <100.00%> (ø)
models/sqlite/message.go 80.50% <100.00%> (+0.83%) ⬆️
service/address_service.go 63.26% <100.00%> (-3.74%) ⬇️
testhelper/mock_data.go 85.27% <100.00%> (ø)
testhelper/utils.go 88.28% <100.00%> (+2.26%) ⬆️
... and 13 more

@LinZexiao LinZexiao force-pushed the feat/improve-docker-usage branch from 4ce3ff4 to 12784ad Compare August 31, 2022 06:03
@hunjixin hunjixin merged commit d2fb10f into master Sep 1, 2022
@hunjixin hunjixin deleted the feat/improve-docker-usage branch September 1, 2022 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants