Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opt/import data #317

Merged
merged 4 commits into from
Apr 13, 2023
Merged

Opt/import data #317

merged 4 commits into from
Apr 13, 2023

Conversation

simlecode
Copy link
Collaborator

关联的Issues (Related Issues)

close filecoin-project/venus#5899

改动 (Proposed Changes)

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

@simlecode simlecode self-assigned this Apr 12, 2023
@simlecode simlecode requested a review from hunjixin April 12, 2023 09:48
@codecov-commenter
Copy link

codecov-commenter commented Apr 12, 2023

Codecov Report

Merging #317 (b359c3c) into master (a478fb0) will decrease coverage by 0.06%.
The diff coverage is 1.65%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #317      +/-   ##
==========================================
- Coverage   22.24%   22.18%   -0.06%     
==========================================
  Files         181      181              
  Lines       21339    21395      +56     
==========================================
+ Hits         4746     4747       +1     
- Misses      15820    15875      +55     
  Partials      773      773              
Flag Coverage Δ
unittests 22.18% <1.65%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/impl/venus_market.go 0.00% <0.00%> (ø)
cli/storage-deals.go 4.81% <0.00%> (-0.08%) ⬇️
storageprovider/deal_handler.go 3.75% <0.00%> (-0.14%) ⬇️
storageprovider/storage_provider.go 30.85% <2.24%> (-2.49%) ⬇️

Copy link
Contributor

@hunjixin hunjixin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hunjixin hunjixin merged commit 3a26f5d into master Apr 13, 2023
@hunjixin hunjixin deleted the opt/import-data branch April 13, 2023 02:08
simlecode pushed a commit that referenced this pull request Apr 13, 2023
hunjixin added a commit that referenced this pull request Apr 13, 2023
Merge pull request #317 from filecoin-project/opt/import-data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[venus-market] Optimize offline deal data import / 优化离线订单数据导入
3 participants