Add support for helm plugins #92
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not entirely sure this is a good idea. See #93 which adds support for helm-secrets. It may be better to just add plugins to the build unconditionally as support for specific helm plugins is added to this project. I'm not actually sure of the value of this PR for arbitrary plugins unless they change behavior of normal helm commands. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds two build args to the Dockerfile:
PLUGINS: A space-separated list of plugin URLs passed to
helm plugin installPLUGIN_DEPS: A space-separated list of alpine packages that are extra dependencies of the plugins to be installed