Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VC707 ethernet block #160

Closed
wants to merge 2 commits into from
Closed

VC707 ethernet block #160

wants to merge 2 commits into from

Conversation

ixiotidi
Copy link

I am adding the Ethernet block I created in order to have a stable IPbus design running in a Xilinx VC707 board

@tswilliams
Copy link
Collaborator

Hi,

Thanks for opening this pull request, and contributing the Ethernet block. (And sorry for the delay in responding.)

As far as I'm aware, this Ethernet block should be equally usable in any SGMII-based 7-series design. Is that correct? If so, could you change the name of the entity/file from eth_vc707_sgmii(.vhd) to eth_7s_smgii(.vhd)?

Cheers,
Tom

@ixiotidi
Copy link
Author

Hi Tom,

thanks for the reply. I will do the change in the next days. However, just to let you know the reason I put that as SGMII in vc707 is because I only have tested in the VC707 board with the marvell chips mounted there. I don't know if another board would require a certain configuration of the IP cores.

Cheers
--Ioannis

@tswilliams
Copy link
Collaborator

Hi,

Since the renaming was easy for me to do, I renamed this Ethernet block in another branch, and merged that branch into the master in pull request #173

So this Ethernet block from this pull request is now present in the master branch of the repo. Thanks again for opening this PR.

Cheers,
Tom

@tswilliams tswilliams closed this Mar 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants