Skip to content
This repository has been archived by the owner on Aug 23, 2020. It is now read-only.

Memory optimization of StateDiff.bytes() to only use 1 new byte array instead of stateMap.size * 2 arrays #1656

Merged
merged 1 commit into from
Nov 17, 2019

Conversation

achabill
Copy link
Contributor

@achabill achabill commented Nov 8, 2019

Description

Performance optimization of StateDiff#bytes to only use 1 new byte array instead of stateMap.size * 2 arrays.

Fixes #603

Type of change

  • Enhancement (a non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines for this project
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas

@achabill achabill changed the title #603 Optimization for issue #603 Nov 9, 2019
Copy link
Contributor

@GalRogozinski GalRogozinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@achabill achabill changed the title Optimization for issue #603 Memory optimization of StateDiff.bytes() to only use 1 new byte array instead of stateMap.size * 2 arrays Nov 11, 2019
@GalRogozinski GalRogozinski merged commit fc7dadb into iotaledger:dev Nov 17, 2019
@GalRogozinski GalRogozinski mentioned this pull request May 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compound concatenation vs Long-form code (aka The array vs the stream)
3 participants