Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(iota-tx-test-runner/docs): documentation of init, run, publish , print-bytecode task commands #5128

Merged
merged 11 commits into from
Feb 11, 2025
Merged

feat(iota-tx-test-runner/docs): documentation of init, run, publish , print-bytecode task commands #5128

merged 11 commits into from
Feb 11, 2025

Conversation

Dkwcs
Copy link
Contributor

@Dkwcs Dkwcs commented Jan 31, 2025 •
edited
Loading

Description of change

Documentation of init,run, publish, print-bytecode task commands in order to have good usage perspective.

Links to any relevant issues

Fixes #5122.

Type of change

  • Documentation Fix

@Dkwcs Dkwcs added the documentation Improvements or additions to documentation label Jan 31, 2025
@Dkwcs Dkwcs requested a review from miker83z January 31, 2025 16:54
@Dkwcs Dkwcs self-assigned this Jan 31, 2025
@vercel Vercel
Copy link

vercel bot commented Jan 31, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
apps-backend ❌ Failed (Inspect) Feb 10, 2025 1:08pm
apps-ui-kit ❌ Failed (Inspect) Feb 10, 2025 1:08pm
rebased-explorer ❌ Failed (Inspect) Feb 10, 2025 1:08pm
wallet-dashboard ❌ Failed (Inspect) Feb 10, 2025 1:08pm

@Dkwcs Dkwcs marked this pull request as ready for review February 3, 2025 10:11
@Dkwcs Dkwcs requested a review from nonast February 3, 2025 10:11
@miker83z miker83z linked an issue Feb 3, 2025 that may be closed by this pull request
[transactional-test-runner] Document Init, Run, Publish, PrintBytecode commands #5122
Closed
miker83z
miker83z requested changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@miker83z miker83z left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since init, run, publish and print-bytecode are fundamental, I would move them up in the list (before "view-object").

For each example write the output that is found in the .exp file (use the real tests files if necessary).

@miker83z
Copy link
Contributor

miker83z commented Feb 4, 2025

Pls also run dprint fmt

lucas-tortora
lucas-tortora reviewed Feb 6, 2025
View reviewed changes
@Dkwcs Dkwcs merged commit 6b76459 into sc-platform/transactional-tests-syntax Feb 11, 2025
19 of 29 checks passed
@Dkwcs Dkwcs deleted the sc-platform/document-init-run-publish-printbytecode-commands branch February 11, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miker83z miker83z miker83z approved these changes

@lucas-tortora lucas-tortora lucas-tortora approved these changes

@nonast nonast Awaiting requested review from nonast

Assignees

@Dkwcs Dkwcs

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[transactional-test-runner] Document Init, Run, Publish, PrintBytecode commands
3 participants
@Dkwcs @miker83z @lucas-tortora