chore(lints): Use expect over allow #4402

DaughterOfMars · 2024-12-09T19:09:36Z

Description of change

Use expect over allow, remove unnecessary allows, and fix some that can be easily fixed.

1.81 stabilizes a new lint level, expect, which allows explicitly noting that a particular lint should occur, and warning if it doesn't. The intended use case for this is temporarily silencing a lint, whether due to lint implementation bugs or ongoing refactoring, while wanting to know when the lint is no longer required.

Links to any relevant issues

Closes #4204

consensus/core/src/storage/mem_store.rs

consensus/core/src/base_committer.rs

consensus/core/src/synchronizer.rs

crates/iota-bridge/src/eth_syncer.rs

crates/iota-core/src/transaction_orchestrator.rs

crates/iota-macros/src/lib.rs

crates/iota-network/src/discovery/builder.rs

thibault-martinez · 2024-12-12T10:24:47Z

There is a warning if you run clippy in release mode (ignore the external-crates ones).

crates/typed-store/src/rocks/mod.rs

crates/iota-types/src/effects/effects_v1.rs

examples/tic-tac-toe/cli/src/turn_cap.rs

crates/iota-json-rpc/src/authority_state.rs

consensus/core/src/storage/mod.rs

crates/iota-bridge/src/action_executor.rs

crates/iota-json-rpc/src/authority_state.rs

consensus/core/src/storage/mod.rs

consensus/core/src/synchronizer.rs

* chore(clippy): Use expect over allow * add comment * fix release warning * revert type complexity allow * review * revert trait config * another revert --------- Co-authored-by: Thibault Martinez <thibault@iota.org>

chore(clippy): Use expect over allow

a6307a9

DaughterOfMars requested review from a team, kodemartin and miker83z as code owners December 9, 2024 19:09

iota-ci added dev-tools Issues related to the Developer Tools Team sc-platform Issues related to the Smart Contract Platform group. labels Dec 9, 2024

Thoralf-M reviewed Dec 10, 2024

View reviewed changes

consensus/core/src/storage/mem_store.rs Show resolved Hide resolved

Thoralf-M reviewed Dec 10, 2024

View reviewed changes

consensus/core/src/base_committer.rs Show resolved Hide resolved

Thoralf-M reviewed Dec 10, 2024

View reviewed changes

consensus/core/src/synchronizer.rs Show resolved Hide resolved

add comment

037f8c5

Thoralf-M approved these changes Dec 10, 2024

View reviewed changes

consensus/core/src/synchronizer.rs Show resolved Hide resolved

jkrvivian approved these changes Dec 11, 2024

View reviewed changes

tomxey approved these changes Dec 11, 2024

View reviewed changes

miker83z approved these changes Dec 11, 2024

View reviewed changes

valeriyr approved these changes Dec 11, 2024

View reviewed changes

lucas-tortora approved these changes Dec 11, 2024

View reviewed changes

DaughterOfMars and others added 2 commits December 11, 2024 09:47

Merge branch 'develop' into dev-tools/allow-to-expect

a82fd8b

Merge branch 'develop' into dev-tools/allow-to-expect

2eaffcd