Fmt version 2 #488
Merged
Fmt version 2 #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thibault-martinez
requested review from
Alex6323,
bingyanglin,
zesterer,
louaykamel and
samuel-rufi
as code owners
zesterer
approved these changes
Mar 26, 2021
|
Can you motivate this PR in the description? Would make it easier to review it? Is rustfmt version "two" a new thing I missed, or is it around for longer already? I see a lot of changes in the files, so I assume version "one" just didn't format those instances for backwards compatibility reasons with rustfmt 1.0. Is there anything else interesting to know to about this? |
|
Some formatting rules can only make it to version 2 because of breaking changes in implementation. Version two is then version one + all the rules that can't make it to version one, it's more complete. It's not new (2 years old) but we discovered it while stumbling upon this rust-lang/rustfmt#4355 (comment). |
thibault-martinez
force-pushed
the
fmt-version-2
branch
from
1ddc3f3 to
f45a48c
Compare
Alex6323
approved these changes
Mar 29, 2021
bingyanglin
approved these changes
Mar 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.