-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cursor Improvements, Type improvements, Printing Support #72
Conversation
…?, etc) and use them in various method calls. If the type is incorrect, return nil as the type.
…lying clang API call and remove incorrect duplicate definition for get_typedef_decl_unerlying_type (not spelling error and previous declaration in the file).
…how a variable in debugger).
I'm fine with this but do you have time to get the tests working? |
BTW, for tests, I'm fine with dropping EOL rubies and EOL clangs. Honestly, if it works with the more recent releases, it's good enough. |
A - weird - two of the failures are the tests that I added which of course did pass locally for me. Will have to see why they didn't on github runner. The other failure I missed, will take a look. Agree on dropping EOL Ruby/clang versions. |
Ah I see - I forgot to check in a c header file I added for tests. So now tests pass again. In addition, I upgraded a couple github actions, dropped Ruby 2.7 and 3.0 and added Ruby 3.3 I also tried adding Clang 16/17/18. Clang 16 results in 1 failure (https://github.com/ioquatix/ffi-clang/actions/runs/8517036714/job/23326973558). Clang 17 results in 20 failures (https://github.com/ioquatix/ffi-clang/actions/runs/8517036714/job/23326973994). And Clang 18 is not yet supported by the llvm action. So I reverted back to Clang 15 since I think those failures are out of scope of this already too large MR and should be dealt with separately. I am happy to look at them once we get this MR wrapped up. |
Thanks, this is awesome work. |
This is a grab bag of commits I have been making. New functionality includes adding printing support and methods to tell if a cursor is a opaque (definition in another translation unit) or forward declaration (definition later in translation unit). The declaration methods are very helpful when auto generating FFI bindings.
If you prefer these commits get separated into different MR's let me know.