Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use ruff linter #128

Merged
merged 10 commits into from
Mar 8, 2023
Merged

use ruff linter #128

merged 10 commits into from
Mar 8, 2023

Conversation

ocefpaf
Copy link
Member

@ocefpaf ocefpaf commented Mar 8, 2023

This should make our CIs a bit faster. In this PR:

  • Use ruff and nbqa to lint the notebooks with
    • pyupgrade (ruff)
    • isort (ruff)
    • flakes (ruff)
    • check-ast (ruff)
    • black

I also run mdformat, pre-commit with the new checks from above, and committed all the changes. Kind of a massive PR with all that but I inspected the pages and did not find any problems that are related to these changes.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@ocefpaf
Copy link
Member Author

ocefpaf commented Mar 8, 2023

Notebooks data_access_notebooks/2017-09-09-hurricane_irma.ipynb and data_access_notebooks/2018-02-20-obis.ipynb are failing. I'll investigate in another PR. This one is already too big for its own sake.

@ocefpaf ocefpaf merged commit 311f2a3 into ioos:main Mar 8, 2023
@ocefpaf ocefpaf deleted the use_ruff branch March 8, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant