adding GTS widget notebook #12
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
@ocefpaf should we close this and start a new PR that you 'own'? I have the notebook locally and can push it into your branch if you start the PR. Turns out we didn't need widgets and could get the data directly from the source, instead of the ERDDAP request. |
The PR ioos/notebooks_demos#398 is yours, no mine. If there is no change there you want to merge we can close this and open a new one.
I can make the data source change in a new PR. I have an original version that did that before we moved to ERDDAP. Is that the only change you want in that notebook? I can do first thing tomorrow. |
# Conflicts: # jupyterbook/content/Code Gallery/data_management_notebooks/2020-10-10-GTS.ipynb
|
I broke something. Probably better if I nuke this and start a fresh PR, |
|
Maybe it's okay? This branch on my fork was really behind so I merged it with main. Now it looks like 65 files changed?! Not what I was going for. Git eludes me today :/ |
|
A rebase should fix (or break it 😄). Let me try it locally first. Hold on... |
|
Did a rebase fix it? |
Argh... This passed under my radar when I switched focus to compliance-checker. I rebased and moved it to the right directory. If you are going to work some more I suggest a git pull before you do anything. This notebook is no longer in |
|
This is good to merge if you think it looks good. I'm done w/ my edits. |
|
The way it is we have zero changes :-/ I wonder if the notebook you had here was already commit or if we made a mistake somewhere. |
|
Okay, forgot to push my version. Sorry for the mix-up, should be alright now. |
|
The failure in FAILED jupyterbook/content/code_gallery/data_access_notebooks/2016-12-19-exploring_csw.ipynb seems to be a temporary network one. Merging... |
need to debug still