Refactor urlopen import
#57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pre-commit seems to be sorted, for the failing test I think we will have to change the URL used in |
ocefpaf
reviewed
Aug 31, 2022
Let's mark that one as known failure. We need to test that against more datasets and I'm looking into that. |
- Import 'urlopen' function from erddapy.erddapy module The 'url_handling' module will be deprecated in the next version of erddapy.
|
Rebased after #58 was merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR modifies the import of the
urlopenfunction to suit new versions of erddapy, where theurl_handlingmodule will be deprecated. It does not break compatibility with older versions (theurlopenfunction is available from theerddapy.erddapymodule).Summary of changes
Side note: while doing this change, I noticed that the
https://erddap-uncabled.oceanobservatories.org/uncabled/erddapURL used intest_standardise_variables_uncabledis no longer valid, so checks will probably fail. There is an ERDDAP server at https://erddap.dataexplorer.oceanobservatories.org/erddap/index.html but I wasn't sure of which dataset to use.