Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable all lints in ruff #337

Merged
merged 2 commits into from
Mar 5, 2024
Merged

enable all lints in ruff #337

merged 2 commits into from
Mar 5, 2024

Conversation

ocefpaf
Copy link
Member

@ocefpaf ocefpaf commented Mar 5, 2024

This PR is a bit overwhelming and touches almost all the files but this is the best time to do this b/c we have only 1 real PR pending. Here we have:

  • all lints in ruff are enabled
  • many docstrings improvements
  • code should be all typed now
  • small performance fixes
  • some functions are now kwargs only and this may be seen as a breaking change, next version should reflect that

I'm planning on self-merging this to avoid conflicts with upcoming PRs.

@ocefpaf ocefpaf merged commit 5e45a0e into ioos:main Mar 5, 2024
13 checks passed
@ocefpaf ocefpaf deleted the ruff_all branch March 5, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant