Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.is_long_time_interval() is deprecated and will be removed #1121

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

ocefpaf
Copy link
Member

@ocefpaf ocefpaf commented Nov 13, 2024

This function is deprecated and will be removed in future versions of cf-units. It is also a single line, making this change "cheaper" than the extra import, unit conversion, and method call we have now.

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.91%. Comparing base (bf6c6ff) to head (066a826).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1121      +/-   ##
===========================================
- Coverage    81.91%   81.91%   -0.01%     
===========================================
  Files           25       25              
  Lines         5225     5224       -1     
  Branches      1163     1163              
===========================================
- Hits          4280     4279       -1     
  Misses         644      644              
  Partials       301      301              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ocefpaf ocefpaf merged commit cf12cf4 into ioos:develop Nov 13, 2024
27 checks passed
@ocefpaf ocefpaf deleted the fix_cf-units_deprecation branch November 13, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant