Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump minimum supported Python to 3.9 #1117

Merged
merged 3 commits into from
Nov 5, 2024
Merged

Conversation

ocefpaf
Copy link
Member

@ocefpaf ocefpaf commented Nov 5, 2024

Fix some future deprecatons/removals.

@ocefpaf ocefpaf marked this pull request as draft November 5, 2024 12:21
@ocefpaf ocefpaf marked this pull request as ready for review November 5, 2024 12:27
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.91%. Comparing base (9099e73) to head (be976c6).
Report is 7 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1117   +/-   ##
========================================
  Coverage    81.91%   81.91%           
========================================
  Files           25       25           
  Lines         5224     5225    +1     
  Branches      1163     1163           
========================================
+ Hits          4279     4280    +1     
  Misses         644      644           
  Partials       301      301           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ocefpaf
Copy link
Member Author

ocefpaf commented Nov 5, 2024

@benjwadams Python 3.8 is EOL and it is not worth to keep supporting it. I'll merge this one but we can revert if you disagree.

@ocefpaf ocefpaf merged commit 62758ca into ioos:develop Nov 5, 2024
27 checks passed
@ocefpaf ocefpaf deleted the py39_compat branch November 5, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant