Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor fixes, left over from #1026 #1028

Merged
merged 2 commits into from
May 19, 2023
Merged

Conversation

ocefpaf
Copy link
Member

@ocefpaf ocefpaf commented May 18, 2023

@benjwadams these changes addresses some of your comment in #1026.

@codecov
Copy link

codecov bot commented May 18, 2023

Codecov Report

Merging #1028 (b902a7b) into develop (07a7874) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop    #1028   +/-   ##
========================================
  Coverage    82.20%   82.20%           
========================================
  Files           24       24           
  Lines         5177     5177           
  Branches      1293     1293           
========================================
  Hits          4256     4256           
  Misses         622      622           
  Partials       299      299           
Impacted Files Coverage Δ
compliance_checker/cf/cf_1_7.py 93.72% <ø> (ø)
compliance_checker/cf/cf_1_9.py 81.33% <ø> (ø)
compliance_checker/ioos.py 83.11% <ø> (ø)
compliance_checker/acdd.py 80.71% <100.00%> (ø)
compliance_checker/cf/cf_1_6.py 89.85% <100.00%> (ø)
compliance_checker/cf/cf_base.py 82.77% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ocefpaf
Copy link
Member Author

ocefpaf commented May 18, 2023

100% green CI 🎉

@ocefpaf ocefpaf requested a review from benjwadams May 18, 2023 13:30
@benjwadams benjwadams merged commit bc95877 into ioos:develop May 19, 2023
@ocefpaf ocefpaf deleted the minor_fix branch May 19, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants