This repository has been archived by the owner on Jan 27, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 33
redux-subspace version 2 - Spliting packages, better middleware support, redux-saga support, improved docs #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subspaced actions can now fire more than once
Still need to fix READMEs and examples Haven't made api changes yet
Fixed package.json of react-redux-subspace
mapState is now optional: default to `(state) => state[namespace]` (from ioof-holdings#32)
Removed `root` node of sub-state - can use middleware
Fixed typescript tests (they would never fail before)
Is the import in https://github.com/mpeyper/redux-subspace/blob/master/packages/react-redux-subspace/src/components/SubspaceProvider.js for subspace correct? Redux-subspace is not in the list of packages in the package.json so how is it resolved? |
My bad, it is in the list. Ignore the comment above. |
jpeyper
approved these changes
Aug 11, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good and test coverage is awesome. Good job.
Docs also seem good, although I think there may be some tweaking over time.
I think we should merge this as is and then fix any docs problems on master.
I'm happy to merge this. I think we should publish to NPM with a canary build until we're happy it's stable. |
This was referenced Aug 15, 2017
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one is huge. I don't think a single line of the version 1 survived. It will probably be easier to just look at or clone my fork than to read this PR, but review however you feel is easiest for you.
The changes here are plentiful:
root
node functionality