Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker command for windows #5

Merged
merged 3 commits into from
Apr 11, 2024
Merged

Fix docker command for windows #5

merged 3 commits into from
Apr 11, 2024

Conversation

kratman
Copy link
Contributor

@kratman kratman commented Apr 11, 2024

Updating the docker load command so that it is compatible with windows

@kratman kratman requested a review from brosaplanella April 11, 2024 13:14
@kratman kratman self-assigned this Apr 11, 2024
valentinsulzer
valentinsulzer previously approved these changes Apr 11, 2024
@valentinsulzer valentinsulzer self-requested a review April 11, 2024 14:24
@valentinsulzer
Copy link
Contributor

ignore my review, I haven't tested it

@kratman
Copy link
Contributor Author

kratman commented Apr 11, 2024

@tinosulzer I requested @brosaplanella Since the problem was found on his machine. I am going to make the other improvements in a different branch

@kratman kratman dismissed valentinsulzer’s stale review April 11, 2024 14:27

Needs to be tested on windows

Copy link

@brosaplanella brosaplanella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That fixed it, thanks Eric!

@kratman kratman merged commit 7d8bd86 into main Apr 11, 2024
2 checks passed
@kratman kratman deleted the feat/windowsFix branch April 11, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants