Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workaround to support k8s v1.29 #59

Merged
merged 3 commits into from
Mar 6, 2024
Merged

Add workaround to support k8s v1.29 #59

merged 3 commits into from
Mar 6, 2024

Conversation

mcbenjemaa
Copy link
Member

@mcbenjemaa mcbenjemaa commented Feb 28, 2024

Workaround for k8s v1.29

Closes #42

Closes #53

@lubedacht
Copy link
Contributor

Wanna update kube-vip version as well?

@mcbenjemaa
Copy link
Member Author

k --kubeconfig test-dev get nodes
NAME                                       STATUS   ROLES           AGE     VERSION-kubeconfig test-dev get nodes                                                                                 ok  kind-vault-onboard kube 
k8s-default-test-dev-control-plane-9zpqh   Ready    control-plane   5m18s   v1.29.2
k8s-default-test-dev-control-plane-msnq6   Ready    control-plane   28s     v1.29.2
k8s-default-test-dev-control-plane-w5s5j   Ready    control-plane   10m     v1.29.2
k8s-default-test-dev-worker-ct6nb          Ready    node            5m35s   v1.29.2
k8s-default-test-dev-worker-tglhn          Ready    node            4m56s   v1.29.2
k8s-default-test-dev-worker-x7vmg          Ready    node            4m31s   v1.29.2

@mcbenjemaa
Copy link
Member Author

  volumes:
  - hostPath:
      path: /etc/kubernetes/super-admin.conf
      type: FileOrCreate
    name: kubeconfig

@mcbenjemaa mcbenjemaa marked this pull request as ready for review March 5, 2024 17:16
Copy link

sonarqubecloud bot commented Mar 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@piepmatz
Copy link
Contributor

piepmatz commented Mar 6, 2024

What about changing back to /etc/kubernetes/admin.conf after /etc/kubernetes/super-admin.conf was used and is no longer required?

@mcbenjemaa
Copy link
Member Author

What about changing back to /etc/kubernetes/admin.conf after /etc/kubernetes/super-admin.conf was used and is no longer required?

We will patch that in future.
But for now kube-vip requires super-admin to initialize.

@mcbenjemaa mcbenjemaa merged commit d1b7a56 into main Mar 6, 2024
7 checks passed
@mcbenjemaa mcbenjemaa deleted the kube-vip-fix branch March 6, 2024 09:32
@piepmatz
Copy link
Contributor

piepmatz commented Mar 6, 2024

What about changing back to /etc/kubernetes/admin.conf after /etc/kubernetes/super-admin.conf was used and is no longer required?

We will patch that in future. But for now kube-vip requires super-admin to initialize.

How do you wanna patch that in the future? As we do this in cloud-init "patching" would require rebuilding the nodes.
What about the approach taken in nutanix-cloud-native/cluster-api-provider-nutanix#382?

@mcbenjemaa
Copy link
Member Author

That approach is actually the same what we are doing.

@piepmatz
Copy link
Contributor

piepmatz commented Mar 6, 2024

In postKubeadmCommands they switch back to admin.conf. We don't, but we should.

@mcbenjemaa
Copy link
Member Author

@piepmatz, you can raise a PR, and I will check that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kube-vip with Kubernetes support v1.29
3 participants