Update FSC to 29.0 #386
Update FSC to 29.0 #386
Conversation
|
did you consider to add redirects? |
|
@forki we need anyway to upgrade FSharpLint, because FCS api changed, so will break at runtime |
|
Makes sense.
Enrico Sada <notifications@github.com> schrieb am Mi., 29. Mai 2019, 17:36:
… @forki <https://github.com/forki> we need anyway to upgrade FSharpLint,
because FCS api changed, so will break at runtime
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#386>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAOANHUKB2NKSTF5OGWXA3PX2PHNANCNFSM4HP2PHNQ>
.
|
|
Still red. ;-( |
|
@forki i know, i am working on that. the FSharpLint added a breaking change (switcher from xml configs to json configs) we need to address first ( ref fsprojects/FSharpLint#347 ) |
the message format is `FS01234: info text"` , strip the warning code
xmlconfig is read and converted, but hint are not disabled changed test, based on current fsharplint behaviour
workaround, remove it from tests. check if is a FCS regression or is FSAC regression
it's flaky, the Range sometimes finish at start of newline other times at end of line
like
```
"Range": {
"StartColumn": 1,
"StartLine": 1,
- "EndColumn": 1,
- "EndLine": 16
+ "EndColumn": 6,
+ "EndLine": 15
},
```
Revert "fcs fixed a bug"
This reverts commit b828456.
|
GREEN |
|
Awesome. 🛳 it |
|
merged. |
|
Lack of misspelling suggestion is breaking change due to dotnet/fsharp#6063 |
|
Should still be able to activate, right?
Krzysztof Cieślak <notifications@github.com> schrieb am Mi., 5. Juni 2019,
12:04:
… Lack of misspelling suggestion is breaking change due to
dotnet/fsharp#6063 <dotnet/fsharp#6063>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#386>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAOANHYLAZOVHCNKJ5QTODPY6FRNANCNFSM4HP2PHNQ>
.
|
|
I think we may do it like VS - error message without suggestion, calculate suggestion when we calculate quick fix. |
|
Sounds good
Krzysztof Cieślak <notifications@github.com> schrieb am Mi., 5. Juni 2019,
12:57:
… I think we may do it like VS - error message without suggestion, calculate
suggestion when we calculate quick fix.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#386>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAOANDP2YUWVBNPIDEW2WDPY6LZNANCNFSM4HP2PHNQ>
.
|
|
Really sad this feature is gone. It was really really nice as is. I like to have the solution in the tooltip directly, in the quickfix is too much work for me as user, while in tooltip helps while typing Also sometimes the suggestion is not really the fix, just a false positive, so dunno, i like quickfix because these always works. |
|
Cc: @cartermp |
No description provided.