Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source link the pdb files #268

Merged
merged 25 commits into from
Jan 11, 2018
Merged

source link the pdb files #268

merged 25 commits into from
Jan 11, 2018

Conversation

ctaggart
Copy link
Contributor

@ctaggart ctaggart commented Dec 28, 2017

Replaces #266 & #267. Same solution as fsharp/fsharp-compiler-docs#842.

@ctaggart
Copy link
Contributor Author

ctaggart commented Dec 28, 2017

@enricosada The tests pass:

C:\Users\camer\cs\SourceLink\build [master ≡]> dotnet sourcelink test "C:\Users\camer\Downloads\fsautocomplete.netcore(1)\fsautocomplete.pdb"
sourcelink test passed: C:\Users\camer\Downloads\fsautocomplete.netcore(1)\fsautocomplete.pdb
C:\Users\camer\cs\SourceLink\build [master ≡]> dotnet sourcelink test "C:\Users\camer\Downloads\fsautocomplete.netcore(1)\FsAutoComplete.Core.VerboseSdkHelper.pdb"
sourcelink test passed: C:\Users\camer\Downloads\fsautocomplete.netcore(1)\FsAutoComplete.Core.VerboseSdkHelper.pdb
C:\Users\camer\cs\SourceLink\build [master ≡]> dotnet sourcelink test "C:\Users\camer\Downloads\fsautocomplete.netcore(1)\FsAutoComplete.Core.pdb"
sourcelink test passed: C:\Users\camer\Downloads\fsautocomplete.netcore(1)\FsAutoComplete.Core.pdb
C:\Users\camer\cs\SourceLink\build [master ≡]> dotnet sourcelink print-json "C:\Users\camer\Downloads\fsautocomplete.netcore(1)\FsAutoComplete.Core.pdb"
{"documents":{"C:\\projects\\fsautocomplete\\*":"https://raw.githubusercontent.com/fsharp/FsAutoComplete/a764462cdb90a2cf8665da6fd232da309ad76030/*"}}

@ctaggart ctaggart mentioned this pull request Dec 28, 2017
15 tasks
@ctaggart
Copy link
Contributor Author

ctaggart commented Jan 7, 2018

If you want the nuget packages to be tested automatically during the build, we can add something like this:
https://github.com/ctaggart/SourceLink/wiki/FAKE
cc @enricosada

@enricosada
Copy link
Contributor

enricosada commented Jan 9, 2018

Sorry for delay @ctaggart , vacations :D.

I'll merge soon.

no need for the additional test, i trust the tool to do his job :D

@enricosada enricosada merged commit 44ff9aa into ionide:master Jan 11, 2018
@enricosada
Copy link
Contributor

Thx @ctaggart !

@ctaggart ctaggart deleted the sourcelink3 branch January 12, 2018 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants