Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update page.setContent to accept all options Pupppeteer accepts #1633

Closed
pr3tori4n opened this issue Jun 12, 2019 · 2 comments
Closed

Update page.setContent to accept all options Pupppeteer accepts #1633

pr3tori4n opened this issue Jun 12, 2019 · 2 comments
Labels

Comments

@pr3tori4n
Copy link

Stencil version:

 @stencil/core@1.0.0

I'm submitting a:
[ ] bug report
[x ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://stencil-worldwide.herokuapp.com/ or https://forum.ionicframework.com/

Requested Feature
The setContent method on Stencil's wrapper around the Puppeteer API should also accept overrides for the options object, specifically for waitUntil.

Related code:

//Expected to work in an end2end test
await page.setContent(`<foo-bar></foo-bar>`, { waitUntil: 'load' })

Other information:

@ionitron-bot ionitron-bot bot added the triage label Jun 12, 2019
@manucorporat
Copy link
Contributor

manucorporat commented Jun 13, 2019

Could you try to make a PR?

@pr3tori4n
Copy link
Author

I believe this has been fixed with this change:
62839d8#diff-48f1f03cd5c6791c397f1ce962aef19a

Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants