Skip to content

Commit

Permalink
fix(e2e): wait for idle network (#1579)
Browse files Browse the repository at this point in the history
  • Loading branch information
bodinaren authored and manucorporat committed May 30, 2019
1 parent 6db9c5d commit f9a323f
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/testing/puppeteer/puppeteer-page.ts
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ async function e2eGoTo(page: pd.E2EPageInternal, url: string) {

const fullUrl = browserUrl + url.substring(1);

const rsp = await page._e2eGoto(fullUrl);
const rsp = await page._e2eGoto(fullUrl, { waitUntil: 'networkidle0' });

if (!rsp.ok()) {
await closePage(page);
Expand Down Expand Up @@ -180,7 +180,7 @@ async function e2eSetContent(page: pd.E2EPageInternal, html: string) {
}
});

const rsp = await page._e2eGoto(url);
const rsp = await page._e2eGoto(url, { waitUntil: 'networkidle0' });

if (!rsp.ok()) {
await closePage(page);
Expand Down

0 comments on commit f9a323f

Please sign in to comment.