fix(input): guarantee ionic input label doesn't have horizontal padding so it's aligned with input outline #30152
+21
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoaoFerreira-FrontEnd
added
package: core
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
- update snapshots;
- update textarea border-color; - update input colors; - update input border radius;
brandyscarney
requested changes
Jan 27, 2025
There was a problem hiding this comment.
We should create a separate task to update the focus color for textarea since we are updating input.
Co-authored-by: Brandy Smith <brandyscarney@users.noreply.github.com>
Co-authored-by: Brandy Smith <brandyscarney@users.noreply.github.com>
Co-authored-by: Brandy Smith <brandyscarney@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
There were a misalignment between the labels' input and the labels' Textarea.
What is the new behavior?
Does this introduce a breaking change?
Other information
input preview
textarea preview